fix(expert): use document from request as fallback when document is not in the store#695
Merged
Conversation
…ot in the store (#693) Looking at #535 the reason is that a file on which a codeAction request is performed is not (yet?) in the `Document.Store` (or maybe was there, but is gone because of `didClose`). This smells like a misbehaving client, but I cannot rule out some kind of race condition too. Anyway, even if we cannot fetch from `Document.Store` for some reason, we should already have a document resolved from the request (by temporary reading from disk). We can use this document as a fallback in such case. Not sure if it fixes #535, because I don't have a repro case, but it's the best shot I have. (cherry picked from commit 5daee68)
katafrakt
commented
May 25, 2026
|
|
||
| def handle_request(request, lsp) do | ||
| with {:ok, handler} <- fetch_handler(request), | ||
| {:ok, request} <- Convert.to_native(request), |
Member
Author
There was a problem hiding this comment.
It seems in v1 we had first Convert.to_native, then check_engine_initialized, but in main the other way around. Not sure when/why this happened.
Member
Author
|
This is a bit non-trivial backport because of differences between v0.1 and main, so if you could have a look when you have time @doorgan I'd be grateful for a second pair of eyes. |
doorgan
approved these changes
May 26, 2026
Contributor
doorgan
left a comment
doorgan
left a comment
There was a problem hiding this comment.
Looks good and worked in my tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #693