fix(expert): omit scrubbed env vars instead of setting to empty string#699
Open
jollyjerr wants to merge 1 commit into
Open
fix(expert): omit scrubbed env vars instead of setting to empty string#699jollyjerr wants to merge 1 commit into
jollyjerr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello expert team 👋🏼 this PR fixes an issue I have been encountering after this pr using this setup:
When launching neovim in a project directory, expert will crash with:
I believe this is happening because we are passing
ROOTDIR=""toerlexechere so we are skipping this logicExample of bug
By omitting
@scrubbed_env_varsentirely, I was able to get expert working again with my setup.I believe this will also be the fix for #637