windows: Add unistd functions to win32#22
Draft
caiosignor wants to merge 16 commits intodevs/expertise/native-windowsfrom
Draft
windows: Add unistd functions to win32#22caiosignor wants to merge 16 commits intodevs/expertise/native-windowsfrom
caiosignor wants to merge 16 commits intodevs/expertise/native-windowsfrom
Conversation
JPTIZ
added
remove-dependency
JPTIZ
force-pushed
the
devs/jptiz/build-on-windows-with-clang-cl
branch
from
cf53b62 to
5892e25
Compare
JPTIZ
changed the base branch from
devs/jptiz/build-on-windows-with-clang-cl
to
devs/expertise/native-windows
caiosignor
changed the title
caiosignor
force-pushed
the
devs/carlos/unistd
branch
from
85c24ae to
7af8f90
Compare
caiosignor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GOALS
This PR aims to solve #4 (Remove unistd.h dependency)
How it work
Windows UCRT contains some equals functions from unistd. So as part of solution, was include
#include <io.h>and#include <process.h>in src/lib/evil/evil_unistd.hThe functions below, not found in ucrt, so, i've implemeted an wrapper that is located in evil_unistd.h
sleepnow isevil_sleepusleepnow isevil_usleepchownnow isevil_chownreadlinknow isevil_readlinksetsidnow isevil_setsidTest
To test it, you need run .\configure && .\build -k0
No build errors should happen related to these functions