Skip to content

Fix openssl include path directory#271

Merged
walac merged 1 commit intoexpertisesolutions:devs/expertise/native-windowsfrom
walac:openssl-fix
Jul 7, 2020
Merged

Fix openssl include path directory#271
walac merged 1 commit intoexpertisesolutions:devs/expertise/native-windowsfrom
walac:openssl-fix

Conversation

@walac
Copy link
Contributor

@walac walac commented Jul 7, 2020

No description provided.

@walac walac requested a review from joaoantoniocardoso July 7, 2020 12:58
@walac walac marked this pull request as draft July 7, 2020 13:00
@joaoantoniocardoso
Copy link
Contributor

joaoantoniocardoso commented Jul 7, 2020

This makes sense with new versions of meson, but what errors are you getting with openssl?

@Coquinho
Copy link
Contributor

Coquinho commented Jul 7, 2020 •
edited
Loading

This makes compilations to break for me:

3 warnings generated.                                   
[471/568] Linking target src/lib/emile/emile-1.dll       
FAILED: src/lib/emile/emile-1.dll src/lib/emile/emile-1.p
db                                                      
lld-link @src/lib/emile/emile-1.dll.rsp                 
lld-link: error: could not open 'libssl_static.lib': no s
uch file or directory                                   
lld-link: error: could not open 'libcrypto_static.lib': n
o such file or directory                                
[492/568] Compiling C objec...ce@exe/interface_main.c.obj
ninja: build stopped: subcommand failed.                
ninja: Entering directory `C:\Users\Lucas\source\repos\ef
l2\build'                                               
[2/77] Linking target src/lib/emile/emile-1.dll          
FAILED: src/lib/emile/emile-1.dll src/lib/emile/emile-1.p
db                                                      
lld-link @src/lib/emile/emile-1.dll.rsp                 
lld-link: error: could not open 'libssl_static.lib': no s
uch file or directory                                   
lld-link: error: could not open 'libcrypto_static.lib': n
o such file or directory                                
[23/77] Compiling C object ...exe/constructors_main.c.obj
ninja: build stopped: subcommand failed.                
Could not rebuild C:\Users\Lucas\source\repos\efl2\build

Is it expected?

@joaoantoniocardoso
Copy link
Contributor

joaoantoniocardoso commented Jul 7, 2020

This makes compilations to break for me:

3 warnings generated.                                   
[471/568] Linking target src/lib/emile/emile-1.dll       
FAILED: src/lib/emile/emile-1.dll src/lib/emile/emile-1.p
db                                                      
lld-link @src/lib/emile/emile-1.dll.rsp                 
lld-link: error: could not open 'libssl_static.lib': no s
uch file or directory                                   
lld-link: error: could not open 'libcrypto_static.lib': n
o such file or directory                                
[492/568] Compiling C objec...ce@exe/interface_main.c.obj
ninja: build stopped: subcommand failed.                
ninja: Entering directory `C:\Users\Lucas\source\repos\ef
l2\build'                                               
[2/77] Linking target src/lib/emile/emile-1.dll          
FAILED: src/lib/emile/emile-1.dll src/lib/emile/emile-1.p
db                                                      
lld-link @src/lib/emile/emile-1.dll.rsp                 
lld-link: error: could not open 'libssl_static.lib': no s
uch file or directory                                   
lld-link: error: could not open 'libcrypto_static.lib': n
o such file or directory                                
[23/77] Compiling C object ...exe/constructors_main.c.obj
ninja: build stopped: subcommand failed.                
Could not rebuild C:\Users\Lucas\source\repos\efl2\build

Is it expected?

Oh, I see, could you try removing that extra / 'lib' added?

@walac
Copy link
Contributor Author

walac commented Jul 7, 2020

This makes sense with new versions of meson, but what errors are you getting with openssl?

The include files are not found.

@joaoantoniocardoso
Copy link
Contributor

joaoantoniocardoso commented Jul 7, 2020 •
edited
Loading

This makes sense with new versions of meson, but what errors are you getting with openssl?

The include files are not found.

Could you check if is this same issue?

@walac
Fix openssl lib paths for prebuilt packages
42d6d6a 
When using prebuilt packages, the library are stored inside the '/lib'
subdirectory.
@walac
Copy link
Contributor Author

walac commented Jul 7, 2020

Could you check if is this same issue?

Yeah, the problem is that I use a prebuilt version of OpenSSL, where the lib files are inside a /lib subdirectory.

@walac walac marked this pull request as ready for review July 7, 2020 13:52
@Coquinho Coquinho self-requested a review July 7, 2020 14:05
Coquinho
Coquinho approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@Coquinho Coquinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works :D

joaoantoniocardoso
joaoantoniocardoso approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I just tested and found no issues here with this mod.

@walac walac merged commit 12dba31 into expertisesolutions:devs/expertise/native-windows Jul 7, 2020
JPTIZ
JPTIZ reviewed Jul 7, 2020
View reviewed changes
meson.build
if (get_option('openssl_dir') != '')
crypto = declare_dependency(
link_args: ['-L' + get_option('openssl_dir'), '-llibssl_static', '-llibcrypto_static'],
link_args: ['-L' + get_option('openssl_dir'), '-L' + get_option('openssl_dir') + '/lib', '-llibssl_static', '-llibcrypto_static'],
Copy link
Contributor

@JPTIZ JPTIZ Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be get_option('openssl_dir') / 'lib', but...

Copy link
Contributor Author

@walac walac Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like the CI has a version of meson that doesn't support the syntax.

Copy link
Contributor

@JPTIZ JPTIZ Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows CI version is always the updated from PyPI (0.54.3), so it should support. Didn't check Travis, tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@JPTIZ JPTIZ JPTIZ left review comments

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

@Coquinho Coquinho Coquinho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@walac @joaoantoniocardoso @Coquinho @JPTIZ