Use eina_file_unlink() instead of unlink()#414
Draft
joaoantoniocardoso wants to merge 3 commits intodevs/expertise/native-windowsfrom
Draft
Use eina_file_unlink() instead of unlink()#414joaoantoniocardoso wants to merge 3 commits intodevs/expertise/native-windowsfrom
joaoantoniocardoso wants to merge 3 commits intodevs/expertise/native-windowsfrom
Conversation
JPTIZ
reviewed
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unlink()function is being used all over the place whereeina_file_unlink()would possibly fit better.Note that here I first used a macro to perform the work, so I am still analyzing if it makes sense. For example in
src/bin/edjethere are several uses ofunlink()that cannot be directly changed toeina_file_unlink()or it won't compile, so I didn't add to this batch.