Refactor E2509 Reimplement feedback_response_map.rb by aanand-1706 · Pull Request #293 · expertiza/reimplementation-back-end

aanand-1706 · 2026-02-23T17:24:35Z

PR being refactored: #182

github-actions · 2026-02-23T17:24:54Z

	2 Warnings
⚠️	Pull request is too big (more than 500 LoC).
⚠️	RSpec tests seem shallow (single `it` blocks or no context). Consider improving test structure.

Generated by 🚫 Danger

… mailer

app/controllers/response_maps_controller.rb

app/mailers/feedback_email_mailer.rb

app/models/response.rb

efg · 2026-03-09T18:00:56Z

app/models/response.rb

+    # Add other response map type email services as needed
+  end
+
+  # Gets all active questions that can be scored


Isn't the code for calculating scores done with a mixin?

app/models/response.rb

efg · 2026-03-09T18:03:04Z

app/models/response_map.rb

+    self.responses.where(is_submitted: true).exists?
+  end
+
+  # Generate a report for responses grouped by rounds


Again, I think reporting should be done in other classes.

efg · 2026-03-09T18:04:14Z

app/models/response_map.rb

+  # Groups responses by their round number
+  # @param responses [ActiveRecord::Relation] the responses to group
+  # @return [Hash] responses grouped by round number
+  def self.group_responses_by_round(responses)


Six class methods is too many. Refactor.

github-actions · 2026-03-18T09:47:06Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present

github-actions · 2026-03-18T16:57:34Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present

github-actions · 2026-03-18T17:03:53Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present

github-actions · 2026-03-23T16:39:39Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present

github-actions · 2026-03-23T16:44:01Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present

github-actions · 2026-03-23T16:58:34Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present
rspec ./spec/models/response_spec.rb:25 # Response#reportable_difference? when count is 0 returns false
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-23T17:02:26Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present

github-actions · 2026-03-23T17:03:12Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present

github-actions · 2026-03-23T17:13:00Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present

efg · 2026-03-18T17:46:31Z

app/controllers/response_maps_controller.rb

+  before_action :set_response_map, only: [:show, :update, :destroy, :submit_response]
+
+  # Lists all response maps in the system
+  # GET /response_maps


Remove this method. You would never want to list all response maps.

app/controllers/response_maps_controller.rb

efg · 2026-03-18T17:49:33Z

app/controllers/response_maps_controller.rb

+    head :no_content
+  end
+
+  # Handles the submission of a response associated with a response map


No, this should "obviously" be a method of responses_controller instead.

app/controllers/response_maps_controller.rb

app/models/response.rb

app/models/response_map.rb

app/models/response.rb

app/models/response_map.rb

github-actions · 2026-03-25T16:07:54Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-25T16:11:03Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-25T16:15:49Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-25T16:18:34Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-25T16:19:15Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-30T19:16:44Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/feedback_response_map_spec.rb:5 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:15 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:26 # FeedbackResponseMap#get_title returns the correct title constant
rspec ./spec/models/feedback_response_map_spec.rb:57 # FeedbackResponseMap#assignment returns the assignment associated with this FeedbackResponseMap
rspec ./spec/models/feedback_response_map_spec.rb:63 # FeedbackResponseMap#title returns "Feedback"
rspec ./spec/models/feedback_response_map_spec.rb:69 # FeedbackResponseMap#questionnaire returns an AuthorFeedbackQuestionnaire
rspec ./spec/models/feedback_response_map_spec.rb:75 # FeedbackResponseMap#contributor returns the reviewee
rspec ./spec/models/feedback_response_map_spec.rb:81 # FeedbackResponseMap#reviewer returns the reviewer
rspec ./spec/models/feedback_response_map_spec.rb:87 # FeedbackResponseMap#round returns the round number of the original review
rspec ./spec/models/feedback_response_map_spec.rb:93 # FeedbackResponseMap#round returns nil if the round number is not present
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-30T19:41:38Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-30T19:51:54Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-30T19:52:20Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-30T19:58:42Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

github-actions · 2026-03-31T03:50:16Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/response_spec.rb:33 # Response#reportable_difference? when count is not 0 when the difference between average score on same artifact from others and current score is bigger than allowed percentage returns true

Add and refactor controller files

31c8168

asreeku added 8 commits February 23, 2026 12:28

Add and refactor mailer file

2bdd981

Added models files

bd5d7dc

Adding config files

ed3c06c

Updated spec files

e5989cf

Updated swagger file

f9b735e

Removing feedback_response_maps_controller

4039843

Moved functionality to response_map

641762f

Adding submit_response in routes; Removing duplicate call to feedback…

a921bdf

… mailer

vihar2712 requested a review from efg March 9, 2026 17:47

efg reviewed Mar 9, 2026

View reviewed changes

aanand-1706 changed the title ~~Refactor https://github.com/expertiza/reimplementation-back-end/pull/182~~ Refactor E2509 Reimplement feedback_response_map.rb Mar 11, 2026

asreeku added 2 commits March 11, 2026 11:44

Fetch the right user to send email to

ba701c5

Merge remote-tracking branch 'upstream/main' into refactor-2509

3dfeeec

asreeku added 7 commits March 18, 2026 07:22

Using better function names; Removing unnecessary explicit join in code

2bb2192

Newline

8fda397

Using visitor pattern for response reports

8582700

Only keeping downcase

c20adcb

Removing duplicate belongs_to; Removing recursive function reviewer

a36241e

Polymorphism for sending mails

bf864be

Renaming

92ab292

Using yml from main

95b406d

asreeku added 2 commits March 23, 2026 12:35

Removing submit_response and index methods

9b391af

Removing persist_and_responsd usage

0c3a942

Removing unused methods

4793399

Adding comments

5d878f1

efg reviewed Mar 23, 2026

View reviewed changes

asreeku added 3 commits March 25, 2026 11:59

Removing report related code; addressing PR comments

a9e5250

Removing report related code

66d761f

Using scopes

a453312

asreeku added 3 commits March 25, 2026 12:11

Add back previous existing code

6bedd9b

Whitespace

1ef190f

Removing unused function

c1672c8

Adding test cases for response_maps_controller

2832892

asreeku added 2 commits March 30, 2026 15:23

Minor issue fix

dff5752

Removed spec file under requests/; Updated model spec file

45c10a9

asreeku added 2 commits March 30, 2026 15:47

Update test cases

ada97a1

Remove extra line

101f50f

Add test cases for feedback mailer

fcb9a30

Conversation

aanand-1706 commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

efg Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

efg Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

efg Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

efg Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

efg Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

aanand-1706 commented Feb 23, 2026 •

edited

Loading

github-actions bot commented Feb 23, 2026 •

edited

Loading