E2601. Reimplement student quizzes#309
Open
MaybeNotArnav wants to merge 19 commits intoexpertiza:mainfrom
Open
E2601. Reimplement student quizzes#309MaybeNotArnav wants to merge 19 commits intoexpertiza:mainfrom
MaybeNotArnav wants to merge 19 commits intoexpertiza:mainfrom
Conversation
Generated by 🚫 Danger |
…f them pass! run 'rails test' and you can see all 30 test cases passing!
run 'rails test' to test all files.
…sponse_controller_test.rb
Feature/test cases has the Rspec testing done for the task_ordering/, student_tasks_controller, responses_controller files.
…e in which the guidelines did not specifically tell us to do.
Rspec tests for student_task_controller, responses_controller, task_ordering/... files done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Student Quiz Reimplementation
Implement ordered quiz→review task sequencing in
StudentTasksControllerusing polymorphic task objects (notquiz_required?/reviewer?conditionals), creating the necessary ResponseMap/Response pairs when both are required and routing both quiz and review throughResponsesController.Implemented
TaskQueue,TaskFactory, and task types underapp/models/task_ordering/(incl.base_task.rb,quiz_task.rb,review_task.rb,task_queue.rb,task_factory.rb).app/controllers/student_tasks_controller.rbandapp/controllers/responses_controller.rbTested
spec/models/task_ordering/base_task_spec.rbspec/models/task_ordering/quiz_task_spec.rbspec/models/task_ordering/review_task_spec.rbspec/models/task_ordering/task_factory_spec.rbspec/models/task_ordering/task_queue_spec.rbspec/requests/api/v1/responses_controller_spec.rbspec/requests/api/v1/student_tasks_controller_spec.rbtest/fixtures/*, plusspec/spec_helper.rb/test/test_helper.rbas needed.How to run tests
bundle exec rspec