E2609 : Frontend: calibration assignments + review reporting#164
Closed
ruju4a wants to merge 0 commit intoexpertiza:mainfrom
Closed
E2609 : Frontend: calibration assignments + review reporting#164ruju4a wants to merge 0 commit intoexpertiza:mainfrom
ruju4a wants to merge 0 commit intoexpertiza:mainfrom
Conversation
johnmweisz
reviewed
Apr 2, 2026
| config.headers["Authorization"] = `Bearer ${token}`; | ||
| return config; | ||
| } else { | ||
| return Promise.reject("Authentication token not found! Please login again."); |
There was a problem hiding this comment.
This forces all API calls to have a token which is arbitrary and should be decided by the API itself. For example password reset cannot use this since the user is not authenticated.
There was a problem hiding this comment.
I think main had this already so you might just need to sync, either way I don't think we want this.
johnmweisz
reviewed
Apr 2, 2026
| @@ -0,0 +1,3 @@ | |||
| # https://www.robotstxt.org/robotstxt.html | |||
There was a problem hiding this comment.
I don't think you want to commit the dist folder, this is a blocker.
johnmweisz
reviewed
Apr 2, 2026
| * Rails API origin. For production Docker/VCL, set VITE_API_BASE_URL at build time | ||
| * (e.g. .env.production: VITE_API_BASE_URL=http://YOUR_VCL_IP:3002). | ||
| */ | ||
| export const API_BASE_URL = ( |
There was a problem hiding this comment.
It's unusual to have an entire file dedicated to one const (ie apiBaseUrl.ts instead of apiConfig or something), but putting that aside, this really should be its own PR, this could become a conflict nightmare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds frontend support for calibration assignments in Expertiza: instructors configure calibration participants and gold-standard reviews, and view how student calibration reviews compare to instructor scores per rubric item. This PR also includes related review report work (ReviewReportPage, reviewData). The UI depends on JSON from new or extended backend endpoints (see Backend contract).
Files changed (calibration + bundled review work)
Assignment / calibration UI
src/pages/Assignments/AssignmentEditor.tsx
src/pages/Assignments/CalibrationReview.tsx
src/pages/Assignments/CalibrationInstructorReview.tsx
src/pages/Assignments/calibrationReportNormalize.ts
src/pages/Assignments/calibrationSummary.ts
src/pages/Assignments/calibrationReportDemo.ts
src/pages/Assignments/AssignmentUtil.ts
Routing
src/App.tsx
Reviews / reporting (bundled with this PR)
src/pages/Reviews/ReviewReportPage.tsx
src/pages/Reviews/reviewData.ts
Tests
src/pages/Assignments/tests/CalibrationReview.test.tsx
src/pages/Assignments/tests/CalibrationInstructorReview.test.tsx
src/pages/Assignments/tests/calibrationReportNormalize.test.ts
src/pages/Assignments/tests/calibrationReportDemo.test.ts
src/pages/Assignments/tests/calibrationSummary.test.ts
src/pages/Assignments/AssignmentEditor.test.tsx
Backend contract (high level)
Document or link to the backend PR: endpoints for calibration_response_maps, add_calibration_participant, begin, calibration_reports/:mapId, and instructor_response. Note alignment with SubmittedContentController-style payloads for hyperlinks/files where applicable.
Changes outside calibration project scope
The branch may contain additional changes that are not part of the calibration or review-report work described above (for example to keep the app running or for other tasks). Reviewers: treat Scope — files as the intended feature scope; other diffs are incidental unless you choose to review them in depth.