Skip to content

fix: support ConstExpr with functions defined via expr.Function #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yanhu007 wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −0
Open

fix: support ConstExpr with functions defined via expr.Function #955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions conf/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,22 @@ func (c *Config) WithEnv(env any) {
}

func (c *Config) ConstExpr(name string) {
// Check if the function is defined via expr.Function first.
if fn, ok := c.Functions[name]; ok {
if fn.Func != nil {
c.ConstFns[name] = reflect.ValueOf(fn.Func)
return
}
if fn.Fast != nil {
c.ConstFns[name] = reflect.ValueOf(fn.Fast)
return
}
if fn.Safe != nil {
c.ConstFns[name] = reflect.ValueOf(fn.Safe)
return
}
panic(fmt.Errorf("const expression %q must have a function implementation", name))
}
if c.EnvObject == nil {
panic("no environment is specified for ConstExpr()")
}
Expand Down
Loading