BlockJoin improvements for Rails applications#23
Open
DougKeller wants to merge 20 commits intoextendi:masterfrom
SynergyDataSystems:master
Open
BlockJoin improvements for Rails applications#23DougKeller wants to merge 20 commits intoextendi:masterfrom SynergyDataSystems:master
DougKeller wants to merge 20 commits intoextendi:masterfrom
SynergyDataSystems:master
Conversation
Author
|
We ultimately ended up going a different route than BJQ for our app due to issues with keeping parent/child docs in sync, so I have deleted our fork of this branch. I'll still leave this PR open in case there's anything valuable in it, however it's unmaintained and isn't totally bug-free. |
Member
|
Hi @DougKeller thank you for the PR, we'll review it. I'm sure there some valuable stuff here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your PR - because this isn't part of the official branch yet, we chose to try out your changes for our Solr needs.
That said, there were a few changes/improvements we had to make to get it up and running for our app. Unfortunately these changes haven't been tested due to time constraints, but I wanted to put up this PR for you to consider some things that may have been missed.
Changes:
child_documentsvaluetypeall_parents_filter, facet values were coming back incorrectly. Changing this to only filter ontype:parentfixed the counts.namecorrectly_childDocuments_in its field list, serialize each_childDocuments_value as aSunspot::Search::Hitorder_by :some_field, :desc, block_join: on_child(Child) { with(...) }