fix: make fetch example tests actually run#153
Merged
Conversation
…perations The asyncFetchTest was being called without await, returning a Promise that couldn't be destructured. Additionally, the Response.text() and Response.json() tests were using .then() callbacks that never executed during synchronous function evaluation. Made greet() async and use await throughout to ensure all Promise-based operations properly resolve before validation. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fetch example's async tests were not running properly. The
asyncFetchTest()function was being called withoutawait, returning a Promise that couldn't be destructured. Additionally, Response body tests using.then()callbacks never executed during synchronous evaluation, so they weren't validating anything.Changes
greet()async to properly await all Promise-based operations.then()callback tests withawaitfor cleaner, blocking validation.then()chain to execute before checksasyncFetchTest()now properly returns test results that get validated🤖 Generated with Claude Code