Fix Python 3.10+ compatibility: use collections.abc.Iterable#47
Open
Mr-Neutr0n wants to merge 1 commit intoeyurtsev:masterfrom
Open
Fix Python 3.10+ compatibility: use collections.abc.Iterable#47Mr-Neutr0n wants to merge 1 commit intoeyurtsev:masterfrom
Mr-Neutr0n wants to merge 1 commit intoeyurtsev:masterfrom
Conversation
Replace deprecated collections.Iterable with collections.abc.Iterable in containers.py. collections.Iterable was deprecated in Python 3.3 and removed in Python 3.10. Related to eyurtsev#44 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
just checking in on this — Python 3.10 moved Iterable from collections to collections.abc. this fixes the resulting ImportError |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collections.Iterablewithcollections.abc.Iterablein containers.pyChanges
import collectionstoimport collections.abcisinstance(gate_lw, collections.Iterable)toisinstance(gate_lw, collections.abc.Iterable)Background
collections.Iterable(and other ABCs) were deprecated in Python 3.3 and removed in Python 3.10. They should be imported fromcollections.abcinstead.This is a follow-up to the fix in #44 which addressed
collections.MutableMapping. Thecollections.Iterableusage was missed.Test plan
Related to #44
🤖 Generated with Claude Code