Open
Conversation
Contributor
bdunogier
commented
Jan 31, 2015
bdunogier
commented
bdunogier
force-pushed
the
bd_sensiolabs_insight
branch
from
0816961 to
8d318f3
Compare
Contributor
|
didn't fully get this one, does it need to be done because of changes in the linked PR? Or is it just a followup? Otherwise no service definition needed to be updated for this? Or link to wrong PR maybe? :) |
Contributor
Author
|
It's just that some of the insight failures were on Legacy things, meaning one more PR with my other insight fix PR on ezpublish-kernel. About services definitions, now that you mention it... weird that it didn't blow up. |
|
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.