Dispatch the CACHE_CLEAR_CONTENT events from the Legacy#57
Open
Plopix wants to merge 1 commit intoezsystems:masterfrom
Plopix:feature-fix-triggering-events
Open
Dispatch the CACHE_CLEAR_CONTENT events from the Legacy#57Plopix wants to merge 1 commit intoezsystems:masterfrom Plopix:feature-fix-triggering-events
Plopix wants to merge 1 commit intoezsystems:masterfrom
Plopix:feature-fix-triggering-events
Conversation
Contributor
Author
|
Ok after few other tests it is prob not the good way to do it for 2 reasons:
It is a purely bridge issue, any idea @bdunogier @andrerom @lolautruche @emodric ? |
Contributor
|
There are other issue around, so actually the cache clearing system is kind of broken, it assume content still exists, which is not the case when you delete/trash it. So recently been investigating doing it differently and/or deprecating that system. Also the reason legacy bridge uses purge is that it is supposed to triggered by cache clearing events in legacy that has already resolved affected nodes. So in summary: @Plopix better if you describe the issue you have, as this does not seem like the right approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the CACHE_CLEAR_CONTENT event is not trigger from the legacy Bridge.
https://doc.ez.no/display/EZP/Smart+HttpCache+clearing
The configuration mapper calls purge
https://github.com/ezsystems/LegacyBridge/blob/master/bundle/LegacyMapper/Configuration.php#L205
And the purge does not dispatch the events:
https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Publish/Core/MVC/Symfony/Cache/Http/InstantCachePurger.php#L54
Note sure about the if ($locationId != 1) but seems needed.
Let me kow!