Skip to content

Bug fix: skip retry on auth failures 401/403 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandrajr merged 1 commit into from
Jul 26, 2026
Merged

Bug fix: skip retry on auth failures 401/403 #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions f5_ctlr_agent/gtm/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,8 +483,11 @@ def is_transient_error(exception):
if hasattr(exception, 'response') and exception.response is not None:
try:
status_code = exception.response.status_code
# Transient HTTP errors
if status_code in {401, 403, 408, 429, 500, 502, 503, 504}:
# Authentication failures (401/403) are PERMANENT — invalid credentials should not retry
if status_code in {401, 403}:
return False
# Transient HTTP errors (server errors, rate limiting, timeouts)
if status_code in {408, 429, 500, 502, 503, 504}:
return True
# Permanent HTTP errors
if status_code in {400, 404, 409, 422}:
Expand All @@ -498,6 +501,9 @@ def is_transient_error(exception):

# Permanent patterns — NEVER retry
PERMANENT_PATTERNS = (
# Authentication failures — invalid credentials
'401', '403', 'unauthorized', 'forbidden',
# Not found / Invalid config
'404', 'not found', 'does not exist',
'was not found', 'is not valid', 'is not allowed',
)
Expand All @@ -506,8 +512,6 @@ def is_transient_error(exception):

# Transient string patterns
TRANSIENT_PATTERNS = (
# Auth (session expired, token stale)
'401', '403',
# Server errors
'500', '502', '503', '504',
# Connection errors
Expand Down