Implement full-fidelity ACP session reuse - #515
Draft
jessmartin wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Follow-up note: the next thing to do here is end-to-end testing of the ACP full-fidelity session reuse path before moving this out of draft or considering merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend="acp"agent nodes with resolvedfidelity="full"to reuse sessions by explicitthread_id, or by an implicit run/parallel-branch scoped key when no explicit thread is set.agent.acp.started.properties.reusedfor observability.thread_idwith mismatched ACP process configuration.Closes #514.
Testing
cargo check -p fabro-acpcargo check -p fabro-workflowcargo check -p fabro-validatecargo check -p fabro-servercargo test -p fabro-validate backend_validcargo test -p fabro-workflow acp_backend_full_fidelitycargo test -p fabro-acpcargo test -p fabro-workflow handler::llm::acp::testscargo +nightly-2026-04-14 fmt --check --allcargo +nightly-2026-04-14 clippy -p fabro-acp -p fabro-workflow -p fabro-validate -p fabro-server --all-targets -- -D warnings