fix(docsite): add DialogHeader property-editor defaults and examples#3731
fix(docsite): add DialogHeader property-editor defaults and examples#3731raphaelroshan wants to merge 1 commit into
Conversation
The DialogHeader docsite page rendered an empty preview because the properties editor had no default prop values, and the page had no example blocks. Add playground defaults (title, subtitle, divider) so the preview is meaningful out of the box, plus example blocks for a basic header, a header with a close button, and one with start/end content. Closes facebook#2719.
|
@raphaelroshan is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @raphaelroshan! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
raphaelroshan
requested review from
cixzhang,
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
1 participant
Closes #2719.
The
DialogHeaderdocsite page didn't preview well. The properties editor had no default values, sotitleandsubtitlerendered empty, and there were no example blocks to copy from.This sets sensible playground defaults — a title, subtitle, and the divider — so the property editor shows a real header immediately, and adds three examples: a basic header, one with a close button (via
onOpenChange), and one using thestartContent/endContentslots.Docs-only change, no API or behavior change. Changeset included.