Skip to content

fix: ignore globby from scanning monorepo node_modules for slowness fix #12129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hariabinesh-l-4219 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Draft

fix: ignore globby from scanning monorepo node_modules for slowness fix #12129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/docusaurus-plugin-content-docs/src/sidebars/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export function resolveSidebarPathOption(
async function readCategoriesMetadata(contentPath: string) {
const categoryFiles = await Globby('**/_category_.{json,yml,yaml}', {
cwd: contentPath,
ignore: ['**/node_modules/**'],

@slorber slorber Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could fix your specific problem, but also introduce problems in other site setups. For example, sites can decide to load their mdx docs from npm and have actual content in node_modules. We need to ensure we keep supporting this pattern with tests, because I'm not sure what's the behavior of Globby.

And we also want to migrate to tinyglobby or eventually native Node globbing API, which may behave differently too. (#11042)

Maybe this will work better? Without any test, it's hard to tell:

ignore: [${contentPath}//node_modules/'],`

@hariabinesh-l-4219 hariabinesh-l-4219 Jun 15, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node_modules will be present inside each of the packages. so passing contentPath is not possible.

});
const categoryToFile = _.groupBy(categoryFiles, path.dirname);
return combinePromises(
Expand Down
Loading