Skip to content

fix(utils): do not read a query from a "?" inside the URL hash #12319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsavy4 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(utils): do not read a query from a "?" inside the URL hash #12319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/docusaurus-utils/src/__tests__/urlUtils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,15 @@ describe('toURLPath', () => {
hash: '',
});
});

it('pathname + hash containing a question mark (no query)', () => {
const url = parseURLOrPath('/pathname#hash?notquery');
expect(toURLPath(url)).toEqual({
pathname: '/pathname',
search: undefined,
hash: 'hash?notquery',
});
});
});

describe('parseLocalURLPath', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/docusaurus-utils/src/urlUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,13 +177,17 @@ export type URLPath = {pathname: string; search?: string; hash?: string};
export function toURLPath(url: URL): URLPath {
const {pathname} = url;

// Only the part before the fragment can contain the query string. A "?"
// inside the hash (e.g. "/foo#bar?baz") must not be read as an empty query.
const beforeHash = url.hash ? url.href.slice(0, -url.hash.length) : url.href;

// Fixes annoying url.search behavior
// "" => undefined
// "?" => ""
// "?param => "param"
const search = url.search
? url.search.slice(1)
: url.href.includes('?')
: beforeHash.includes('?')
? ''
: undefined;

Expand Down