docs: fix two dead external links (Create React App, Eta syntax) - #12338
docs: fix two dead external links (Create React App, Eta syntax)#12338paul-madut wants to merge 1 commit into
Conversation
|
Hi @paul-madut! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
Motivation
Two links in the docs return 404. Both point at sites that reorganised after the docs were written.
styling-layoutfacebook.github.io/create-react-app/...-> 404create-react-app.dev/docs/adding-a-css-modules-stylesheet/-> 200api/docusaurus.config.jseta.js.org/docs/syntax#syntax-overview-> 404eta.js.org/docs/syntax/template-syntax-> 200For Eta I used the unversioned path.
eta.js.org/docs/syntax/template-syntax302s to the current/docs/4.x.x/..., so it will not rot again on the next Eta major. The destination page is titled "Template Syntax", which is what the sentence refers to.Test Plan
I extracted all 432 external URLs from
website/docsand checked each one. Beyond these two, everything either returns 200, is an intentional placeholder (mysite.com,my-org.github.io), or 403s because the host blocks automated requests (npmjs, StackOverflow, Algolia) - those are fine in a browser, so I left them alone.One I did not touch
migration/v3.mdxlinks an MDX v1 playground atmdx-git-renovate-babel-monorepo-mdx.vercel.app/playground/, which is also dead. That was an ephemeral Vercel preview for a Renovate branch that no longer exists, and I could not find a permanent MDX v1 playground to replace it with. Removing the bullet outright felt like a content decision for a maintainer rather than a link fix, so I left it and am flagging it here.