fix(vcs): handle MSYS/Git Bash POSIX paths on Windows - #12341
Open
yash2277-ctrl wants to merge 1 commit into
Open
fix(vcs): handle MSYS/Git Bash POSIX paths on Windows#12341yash2277-ctrl wants to merge 1 commit into
yash2277-ctrl wants to merge 1 commit into
Conversation
Fixes facebook#11920%0A%0AGit on Windows (when using MSYS/Git Bash) returns POSIX-style paths like /p/projets/... which need to be converted to Windows paths like P:\projets\... before being used with fs.realpath()%0A%0AThis commit adds a normalizeMSYSPath() function that:%0A- Detects Windows platform%0A- Matches MSYS paths pattern (/[drive letter]/...)%0A- Converts to proper Windows format (DRIVE:\...)%0A- Applies the conversion in getGitRepoRoot() and getGitSuperProjectRoot()%0A%0AThis prevents 'ENOENT: no such file or directory' errors when building Docusaurus sites on Windows with Git Bash.
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical bug on Windows where builds fail due to incorrect Git POSIX path conversion.
Fixes
Closes #11920
Problem
When using Git on Windows with MSYS/Git Bash, git rev-parse --show-toplevel returns POSIX-style paths like /p/projets/my-repo. However, fs.realpath() expects Windows paths like P:\projets\my-repo, causing builds to fail with:
ENOENT: no such file or directory, realpath 'P:\p\projets\my-repo'
Solution
Added normalizeMSYSPath() function that:
Changes
Testing
This fix addresses the exact pattern described in #11920:
Impact
Type of Change