Skip to content

fix destructor call in circular_queue pop_front count#140

Open
rootvector2 wants to merge 1 commit intofacebook:mainfrom
rootvector2:fix-pop-front-destructor
Open

fix destructor call in circular_queue pop_front count#140
rootvector2 wants to merge 1 commit intofacebook:mainfrom
rootvector2:fix-pop-front-destructor

Conversation

@rootvector2
Copy link

see in circular_queue pop_front with count there is one small mistake queue offset destructor is called directly but it should call value destructor because queue element is union item_t and destructor must be called on value clang is giving compile error when using std string i changed it to queue offset dot value destructor and tested with std string in wrapping case now it compiles and works fine

@meta-cla
Copy link

meta-cla bot commented Mar 1, 2026

Hi @rootvector2!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Mar 1, 2026
@meta-cla
Copy link

meta-cla bot commented Mar 1, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-codesync
Copy link

meta-codesync bot commented Mar 5, 2026

@yfeldblum has imported this pull request. If you are a Meta employee, you can view this in D95416010.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant