Skip to content

[Celestica] Tahansb800bcm: Add QSFP and LED service support for tahansb800bcm#1188

Open
joywu-coder wants to merge 1 commit into
facebook:mainfrom
joywu-coder:joy_netlake20_qsfp
Open

[Celestica] Tahansb800bcm: Add QSFP and LED service support for tahansb800bcm#1188
joywu-coder wants to merge 1 commit into
facebook:mainfrom
joywu-coder:joy_netlake20_qsfp

Conversation

@joywu-coder
Copy link
Copy Markdown
Contributor

@joywu-coder joywu-coder commented May 13, 2026

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Following the tahansb800bcm platform support for Netlake2.0 ([PR#1186]), this update registers the platform in PlatformProductInfo.cpp. This enablement allows the platform to leverage existing qsfp_service and led_service logic. By ensuring correct PlatformType identification, it also enables the successful execution of qsfp_hw_test and led_service_hw_test without necessitating redundant hardware-specific code.

Test Plan

  • qsfp_hw_test:
  1. Run T0 QSFP tests with the "mode": "tahansb800bcm" in qsfp.conf.
  2. Run T0 QSFP tests with the "Product Name": "TAHANSB800BCM" in fruid.json.
  3. Result: Platform identified successfully; all functional tests PASSED.
  4. Execution Command:
    ./bin/run_test.py qsfp --qsfp-config ./qsfp.conf --filter_file=./share/hw_sanity_tests/t0_qsfp_hw_tests.conf >& t0_qsfp_hw_tests.log &
  • led_service_hw_test:
  1. Run led_service_hw_test with the "mode": "tahansb800bcm" in led.conf.
  2. Run led_service_hw_test the "Product Name": "TAHANSB800BCM" in fruid.json.
  3. Result: Platform identified successfully; all functional tests PASSED.
  4. Execution Commands:
    ./bin/led_service_hw_test --logging=DBG --gtest_filter=LedServiceTest.checkLedColorChange --led-config ./led.conf --visual_delay_sec 1 >& checkLedColorChange.log &
    ./bin/led_service_hw_test --logging=DBG --gtest_filter=LedServiceTest.checkLedBlinking --led-config ./led.conf --visual_delay_sec 1 >& checkLedBlinking.log &

@meta-cla meta-cla Bot added the CLA Signed label May 13, 2026
@joywu-coder joywu-coder marked this pull request as ready for review May 13, 2026 09:17
@joywu-coder joywu-coder requested a review from a team as a code owner May 13, 2026 09:17
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 14, 2026

@harshitgulati18 has imported this pull request. If you are a Meta employee, you can view this in D105170114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants