[Celestica] Tahansb800bcm: Add QSFP and LED service support for tahansb800bcm#1188
Open
joywu-coder wants to merge 1 commit into
Open
[Celestica] Tahansb800bcm: Add QSFP and LED service support for tahansb800bcm#1188joywu-coder wants to merge 1 commit into
joywu-coder wants to merge 1 commit into
Conversation
harshitgulati18
approved these changes
May 14, 2026
Contributor
|
@harshitgulati18 has imported this pull request. If you are a Meta employee, you can view this in D105170114. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Following the tahansb800bcm platform support for Netlake2.0 ([PR#1186]), this update registers the platform in PlatformProductInfo.cpp. This enablement allows the platform to leverage existing qsfp_service and led_service logic. By ensuring correct PlatformType identification, it also enables the successful execution of qsfp_hw_test and led_service_hw_test without necessitating redundant hardware-specific code.
Test Plan
./bin/run_test.py qsfp --qsfp-config ./qsfp.conf --filter_file=./share/hw_sanity_tests/t0_qsfp_hw_tests.conf >& t0_qsfp_hw_tests.log &
./bin/led_service_hw_test --logging=DBG --gtest_filter=LedServiceTest.checkLedColorChange --led-config ./led.conf --visual_delay_sec 1 >& checkLedColorChange.log &
./bin/led_service_hw_test --logging=DBG --gtest_filter=LedServiceTest.checkLedBlinking --led-config ./led.conf --visual_delay_sec 1 >& checkLedBlinking.log &
Please see the detailed logs: Netlake2.0_tahansb800bcm_oss_qsfp_led_service_hw_test_logs