Skip to content

[Celestica] Icecube: Config: Add TRVDD sensor support for SMB v3.1.10 (PVT Bring-up)#1206

Open
zhongedward wants to merge 1 commit into
facebook:mainfrom
zhongedward:add_smb_sensor_v3.1.10_pvt_bring_up
Open

[Celestica] Icecube: Config: Add TRVDD sensor support for SMB v3.1.10 (PVT Bring-up)#1206
zhongedward wants to merge 1 commit into
facebook:mainfrom
zhongedward:add_smb_sensor_v3.1.10_pvt_bring_up

Conversation

@zhongedward
Copy link
Copy Markdown
Contributor

@zhongedward zhongedward commented May 19, 2026

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
icecube_sensor

Summary

As part of the Icecube PVT bring-up process, new SMB (System Main Board) units have been manufactured with version combination 3.1.10 (Production State: 3, Version: 1, Sub-version: 10).

This PR adds the necessary sensor configuration block in sensor_service.json to support these new units. Without this change, the sensor_service would fail to correctly associate and monitor the voltage rails for this specific hardware revision.

The update specifically includes VOUT monitoring for the four SMB TRVDD rails (Phase 0-3), mapped to in4_input on their respective voltage monitor chips:

  • SMB_XP0R72V_PB_TRVDD_0_VOUT -> SMB_ASIC_VOLTAGE_0
  • SMB_XP0R72V_PB_TRVDD_1_VOUT -> SMB_ASIC_VOLTAGE_6
  • SMB_XP0R72V_PB_TRVDD_2_VOUT -> SMB_ASIC_VOLTAGE_3
  • SMB_XP0R72V_PB_TRVDD_3_VOUT -> SMB_ASIC_VOLTAGE_7

Test Plan

  1. Syntax Validation: Validated JSON syntax.

  2. Formatting: Pretty-printed configurations using the jq command for readability.

  3. Build & Config Tests: Compilation and configuration validation tests passed successfully.

  4. Service Verification: Confirmed that the following services start and run without errors:

    • platform_manager
    • sensor_service/sensor_service_client/sensor_service_sw_test/sensor_service_hw_test
  5. Hardware Identification: Verified the SMB version (3.1.10) is correctly identified via FRU/EEPROM utility during initial bring-up.

  6. Voltage Audit: Confirmed TRVDD voltage readings are within the nominal 0.72V range (verified via sensor_service_client).

Attachments:

icecube_platform_manager_2026_04_29_log.txt
icecube_sensor_service_2026_04_29_log.txt
icecube_sensor_service_client_2026_04_29_log.txt
icecube_sensor_service_hw_test_2026_04_29_log.txt
icecube_sensor_service_sw_test_2026_04_29_log.txt

@meta-cla meta-cla Bot added the CLA Signed label May 19, 2026
@zhongedward zhongedward marked this pull request as ready for review May 19, 2026 02:59
@zhongedward zhongedward requested a review from a team as a code owner May 19, 2026 02:59
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 22, 2026

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D106028095.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant