[Celestica] rma-showtech: get GPIO line value of current direction in rma-showtech GPIO show#1209
Open
CliffyWong wants to merge 1 commit into
Open
[Celestica] rma-showtech: get GPIO line value of current direction in rma-showtech GPIO show#1209CliffyWong wants to merge 1 commit into
CliffyWong wants to merge 1 commit into
Conversation
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D106028029. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This pull introduces a safe method for reading GPIO line values without altering the pin's current direction.
Motivation
rma-showtech invokes GpiodLine::getValue() to display GPIO pin states. However, getValue() internally calls gpiod_line_request_input(), which forcibly changes the GPIO pin direction to input mode. This behavior can lead to a mismatch with the actual hardware state and may even disrupt ongoing services.
Therefore, introduce a function,GpiodLine::getLineValue(), which reads the GPIO state while respecting its currently direction and integrates it into rma-showtech. This ensures that the rma-showtech GPIO display is non-disruptive.
The modifications include:
Test Plan
Before gpioset:

After gpioset:
