[Nexthop] Restrict stable_hashes tarball extraction to hashes and manifests only#1212
Open
benoit-nexthop wants to merge 1 commit into
Open
[Nexthop] Restrict stable_hashes tarball extraction to hashes and manifests only#1212benoit-nexthop wants to merge 1 commit into
benoit-nexthop wants to merge 1 commit into
Conversation
The tarball at fboss/oss/stable_commits/latest_stable_hashes.tar.gz contains stale copies of build/fbcode_builder/getdeps/*.py and other build infrastructure files dated 2026-05-14. Extracting it wholesale was silently overwriting the repo's current versions, including build/fbcode_builder/getdeps/cli.py, reverting the conflict-fix that removed the check_built guard from TestCmd and breaking CI with "project fboss has not been built". Scope the extraction to the two directories it is actually meant to update: build/deps/github_hashes/ and build/fbcode_builder/manifests/. Had to fix various ruff-related complaints in docker-build.py to keep pre-commit check happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
The tarball at
fboss/oss/stable_commits/latest_stable_hashes.tar.gzcontains stale copies ofbuild/fbcode_builder/getdeps/*.pyand other build infrastructure files. Extracting it wholesale was silently overwriting the repo's current versions, includingbuild/fbcode_builder/getdeps/cli.py, reverting local changes and fixes that might exist in the current branch / fork.Scope the extraction to the two directories it is actually meant to update:
build/deps/github_hashes/andbuild/fbcode_builder/manifests/.Had to fix various ruff-related complaints in docker-build.py to keep pre-commit check happy.
Test Plan
Not needed.