[Accton][MINIPACK3NM] Enable QSFP and LED service support for minipack3nm#1225
Open
ec-michael-shih wants to merge 1 commit into
Conversation
…k3nm Signed-off-by: michael_shih <michael_shih@accton.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit install
Summary
Since the Minipack3n platform has migrated its COMe from the previous module to Netlake2 (AMD), the existing platform_manager.json is no longer compatible with the new CPU configuration.
To support this transition while maintaining system identity, a new platform name, minipack3nm, has been introduced.
Given that the underlying hardware layout remains identical to the previous version, this update adds minipack3nm to PlatformProductInfo.cpp within the Minipack3n framework.
This allows the new platform to leverage existing
qsfp_serviceandled_servicelogic,as well as pass
qsfp_hw_testandled_service_hw_testthrough properPlatformTypeidentification without requiring redundant hardware-specific implementations.Test Plan
step1. Copy minipack3n.materialized_JSON to
minipack3nm.materialized_JSONin qsfp-config.step2. Modify the
modein the new JSON fromminipack3ntominipack3nm.step3. Goal: Confirm that the FBOSS framework can successfully recognize the
minipack3nmplatform identifier.Generate led.conf with the mode field set to minipack3nm
Test Result:
minipact3nm_t0_qsfp_hw_test.log.zip
2-1. led_service_hw_test led color change test result:
minipact3nm_led_color_change.log
2-2. led_service_hw_test led blinking test result:
minipact3nm_led_blinking_test.log