Skip to content

Cherry-pick: Set home object correctly in object literal accessors #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramonclaudio wants to merge 1 commit into
base: 250829098.0.0-stable
Choose a base branch
from
+18 −2
Open

Cherry-pick: Set home object correctly in object literal accessors #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/IRGen/ESTreeIRGen-expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1634,7 +1634,7 @@ Value *ESTreeIRGen::genObjectExpr(ESTree::ObjectExpressionNode *Expr) {
Builder.createIdentifier("get " + keyStr.str()),
/* superClassNode */ nullptr,
Function::DefinitionKind::ES5Function,
/* homeObject */ nullptr,
/* homeObject */ capturedObj,
/* parentNode */ propValue->getterProp);
}

Expand All @@ -1645,7 +1645,7 @@ Value *ESTreeIRGen::genObjectExpr(ESTree::ObjectExpressionNode *Expr) {
Builder.createIdentifier("set " + keyStr.str()),
/* superClassNode */ nullptr,
Function::DefinitionKind::ES5Function,
/* homeObject */ nullptr,
/* homeObject */ capturedObj,
/* parentNode */ propValue->setterProp);
}

Expand Down
16 changes: 16 additions & 0 deletions test/hermes/object-literal-getter-super.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,19 @@ var object = {
Object.setPrototypeOf(object, proto);
print(object.a);
// CHECK: a proto m

// Test that accessors without computed names can also refer to super.
(function () {
let v1 = {
get a() {
let x = super.m;
print(x);
}
}
let parent = { m: 12 };
v1.a;
// CHECK-NEXT: undefined
Object.setPrototypeOf(v1, parent);
v1.a;
// CHECK-NEXT: 12
})();