chore: replace micromatch with picomatch#685
Conversation
Replace micromatch with picomatch for glob matching in ignoreFiles.js. Only micromatch.isMatch() was used, which maps directly to picomatch.isMatch(). picomatch has no dependencies and a smaller install size (83 kB vs 235 kB). Closes facebook#603 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@roli-lpci is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @roli-lpci! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
CLA has been signed. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Summary
Replace
micromatchwithpicomatchfor glob matching inignoreFiles.js.micromatch.isMatch()was used, which maps directly topicomatch.isMatch()(identical API — picomatch is the engine inside micromatch)picomatchhas zero dependencies and a smaller install size (83 kB vs 235 kB)Closes #603
Test plan
picomatch.isMatch()accepts the same signature:(string, patterns, options)including array patterns{ dot: true }option is supported by picomatch