Open
Conversation
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
Mar 5, 2026
Summary: Pull Request resolved: facebook#466 Differential Revision: D95407296
jlee303
force-pushed
the
export-D95407296
branch
from
2ec4a1e to
aa02119
Compare
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
Mar 12, 2026
Summary: XGBoost is only needed when building zli and tests, make it a conditional dependency instead of downloading it for all targets. Downloading for all targets can cause issues when linking, repro by linking anything against libopenzl which triggers a missing xgboost warning. Here is a sample [file](https://www.internalfb.com/phabricator/paste/view/P2220351956) I used and command for repro: ``` gcc hello_openzl.c -I ~/fbsource/fbcode/openzl/dev/include/ -L ~/fbsource/fbcode/openzl/dev/ -lopenzl -lpthread -o hello_openzl ``` Differential Revision: D95407296
jlee303
force-pushed
the
export-D95407296
branch
from
aa02119 to
e9d051a
Compare
jlee303
added a commit
to jlee303/openzl-1
that referenced
this pull request
Mar 12, 2026
Summary: XGBoost is only needed when building zli and tests, make it a conditional dependency instead of downloading it for all targets. Downloading for all targets can cause issues when linking, repro by linking anything against libopenzl which triggers a missing xgboost warning. Here is a sample [file](https://www.internalfb.com/phabricator/paste/view/P2220351956) I used and command for repro: ``` gcc hello_openzl.c -I ~/fbsource/fbcode/openzl/dev/include/ -L ~/fbsource/fbcode/openzl/dev/ -lopenzl -lpthread -o hello_openzl ``` Differential Revision: D95407296
jlee303
force-pushed
the
export-D95407296
branch
from
e9d051a to
7ef07aa
Compare
Summary: Pull Request resolved: facebook#466 XGBoost is only needed when building zli and tests, make it a conditional dependency instead of downloading it for all targets. Downloading for all targets can cause issues when linking, repro by linking anything against libopenzl which triggers a missing xgboost warning. Here is a sample [file](https://www.internalfb.com/phabricator/paste/view/P2220351956) I used and command for repro: ``` gcc hello_openzl.c -I ~/fbsource/fbcode/openzl/dev/include/ -L ~/fbsource/fbcode/openzl/dev/ -lopenzl -lpthread -o hello_openzl ``` Differential Revision: D95407296
jlee303
force-pushed
the
export-D95407296
branch
from
7ef07aa to
6f1cdef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D95407296