Open
Conversation
Summary: This API is a pared down version that pushes a lot of the heavy lifting into the ZL_DictLoader implementation. Rather than fully specifying the dict store construct, we create a minimal API that enables the integration with Managed Compression and is sufficient for the purposes of the cctx/dctx. Note the use of C++ in the definitions of the ZL_DictLoader itself. I anticipate our biggest use cases will be sophisticated systems like Managed Compression, for whom an ergonomic C++ interface is a P0. The C API will use the same tricks as we have always used to enable C++ class semantics. Differential Revision: D95292077
Differential Revision: D95403498
Differential Revision: D95832106
|
@Victor-C-Zhang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95832106. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D95832106