Disallow member access on conditional record fields (#505)#505
Closed
daniellerozenblit wants to merge 1 commit intofacebook:devfrom
Closed
Disallow member access on conditional record fields (#505)#505daniellerozenblit wants to merge 1 commit intofacebook:devfrom
daniellerozenblit wants to merge 1 commit intofacebook:devfrom
Conversation
|
@daniellerozenblit has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96347373. |
daniellerozenblit
force-pushed
the
export-D96347373
branch
from
3535f6f to
146166a
Compare
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 12, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 12, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
daniellerozenblit
force-pushed
the
export-D96347373
branch
from
146166a to
b15bd6f
Compare
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 12, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 12, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
meta-codesync
bot
changed the title
daniellerozenblit
force-pushed
the
export-D96347373
branch
from
b15bd6f to
8372202
Compare
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 16, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 16, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
daniellerozenblit
force-pushed
the
export-D96347373
branch
from
8372202 to
e4e89c1
Compare
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 16, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 16, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 17, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 17, 2026
Summary: Pull Request resolved: facebook#505 ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Differential Revision: D96347373
Summary: ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Reviewed By: Cyan4973 Differential Revision: D96347373
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Mar 18, 2026
Summary: ## Stack The goal of this stack is to add support for conditional `when` blocks to sddl. ## Diff Add semantic analysis check to prevent member access (e.g., `data.optional`) on fields declared inside `when` blocks. Conditional fields may or may not exist at runtime depending on the `when` condition, so allowing direct member access would lead to undefined behavior. Reviewed By: Cyan4973 Differential Revision: D96347373
daniellerozenblit
force-pushed
the
export-D96347373
branch
from
e4e89c1 to
1deb7c3
Compare
|
This pull request has been merged in 0653f7b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Stack
The goal of this stack is to add support for conditional
whenblocks to sddl.Diff
Add semantic analysis check to prevent member access (e.g.,
data.optional) on fields declared insidewhenblocks.Conditional fields may or may not exist at runtime depending on the
whencondition, so allowing direct member access would lead to undefined behavior.Reviewed By: Cyan4973
Differential Revision: D96347373