Refactor processStream (#510)#510
Closed
terrelln wants to merge 2 commits intofacebook:devfrom
Closed
Conversation
meta-codesync
Bot
changed the title
processStreamprocessStream (#510)
terrelln
force-pushed
the
export-D96396998
branch
from
3f3190a to
e8d3b39
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 13, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 13, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 13, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 13, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 13, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 13, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 16, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 16, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 16, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 16, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
force-pushed
the
export-D96396998
branch
from
e8d3b39 to
ffaa3dc
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 16, 2026
Summary: Pull Request resolved: facebook#510 Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Differential Revision: D96396998
terrelln
force-pushed
the
export-D96396998
branch
from
ffaa3dc to
e9a56f2
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 23, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 23, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
force-pushed
the
export-D96396998
branch
from
e9a56f2 to
d7e1aa1
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 23, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
force-pushed
the
export-D96396998
branch
from
d7e1aa1 to
db675d3
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 23, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 23, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 23, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 23, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
force-pushed
the
export-D96396998
branch
from
db675d3 to
7ff2c86
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 23, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 23, 2026
Summary: Pull Request resolved: facebook#510 Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
force-pushed
the
export-D96396998
branch
from
7ff2c86 to
edebbdb
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 30, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 30, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 30, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
force-pushed
the
export-D96396998
branch
2 times, most recently
from
73a61f8 to
823ba9a
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 30, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 30, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 30, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 30, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Mar 30, 2026
Summary: Pull Request resolved: facebook#510 Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
force-pushed
the
export-D96396998
branch
from
823ba9a to
0533aa9
Compare
Summary: Improve the ability to catch OOB-access and use-after-free bugs in OpenZL's arenas by using memory poisoning. Reviewed By: Cyan4973 Differential Revision: D96393907
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
terrelln
force-pushed
the
export-D96396998
branch
from
0533aa9 to
cbe8b87
Compare
terrelln
added a commit
to terrelln/openzl
that referenced
this pull request
Apr 1, 2026
Summary: Refactor `processStream` and rename to `runDecoder`. As part of the refactor I: 1. Moved all validation that can be done at header decode time to `fillStoredStreams()` 2. Split the function up into smaller helpers 3. Removed a check that the regenerated streams aren't filled, because we already check this in `fillStoredStreams()` 4. Deleted the `transformInputStreams` vector and use the `workspaceArena` instead Reviewed By: Cyan4973 Differential Revision: D96396998
|
This pull request has been merged in d80583a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor
processStreamand rename torunDecoder. As part of the refactor I:fillStoredStreams()fillStoredStreams()transformInputStreamsvector and use theworkspaceArenainsteadReviewed By: Cyan4973
Differential Revision: D96396998