Stage 3a: Rename and refactor compress trace files, extract shared ChunkTraceCore#537
Open
Victor-C-Zhang wants to merge 1 commit intofacebook:devfrom
Open
Stage 3a: Rename and refactor compress trace files, extract shared ChunkTraceCore#537Victor-C-Zhang wants to merge 1 commit intofacebook:devfrom
Victor-C-Zhang wants to merge 1 commit intofacebook:devfrom
Conversation
…unkTraceCore Summary: Renames compress-side trace files for clarity and extracts shared logic into a reusable static helper class `ChunkTraceCore`: - Renames `ChunkTrace` → `CompressChunkTrace` and `Tracer` → `CompressTracer` to clarify that these are compress-specific, making room for their decompress counterparts - Extracts `initTrace()`, `finalizeUnconsumedStreams()`, `serializeChunkDataToCBOR()`, and `writeSerializedStreamdump()` into `ChunkTraceCore` — previously duplicated logic that will be shared with the decompress side - Moves `StreamdumpEntry` and `TraceResult` structs to namespace scope in `ChunkTraceCore.hpp` for reuse by both compress and decompress sides Pure refactor — no behavioral changes. Differential Revision: D96836952
|
@Victor-C-Zhang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96836952. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Renames compress-side trace files for clarity and extracts shared logic
into a reusable static helper class
ChunkTraceCore:Renames
ChunkTrace→CompressChunkTraceandTracer→CompressTracerto clarify that these are compress-specific, makingroom for their decompress counterparts
Extracts
initTrace(),finalizeUnconsumedStreams(),serializeChunkDataToCBOR(), andwriteSerializedStreamdump()intoChunkTraceCore— previously duplicated logic that will be sharedwith the decompress side
Moves
StreamdumpEntryandTraceResultstructs to namespace scopein
ChunkTraceCore.hppfor reuse by both compress and decompress sidesPure refactor — no behavioral changes.
Differential Revision: D96836952