fix type parameter missing a * #3067#3114
Open
asukaminato0721 wants to merge 1 commit intofacebook:mainfrom
Open
fix type parameter missing a * #3067#3114asukaminato0721 wants to merge 1 commit intofacebook:mainfrom
asukaminato0721 wants to merge 1 commit intofacebook:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes incorrect type argument display for TypeVarTuple parameters in pyrefly_types so that direct TypeVarTuple arguments render with the required unpack marker (*Shape) while avoiding double-unpacking for already-unpacked inputs (**...).
Changes:
- Update
TypeDisplayContext::fmt_targto handleTypeVarTupleparameters across tuple, unpack, and direct-TypeVarTupleargument cases. - Add a unit test asserting
TupleParam[*Shape]rendering for a directTypeVarTupleargument.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3067
the type display path was dropping the unpack marker for direct TypeVarTuple arguments, so Shape rendered bare where
*Shapewas required.fmt_targnow preserves * for direct TypeVarTuple arguments while still avoiding**...for already-unpacked inputs.Test Plan
add test