Open
Conversation
GunniBusch
changed the title
|
@xuhdev has imported this pull request. If you are a Meta employee, you can view this in D101099802. |
xuhdev
reviewed
Apr 16, 2026
xuhdev
reviewed
Apr 16, 2026
GunniBusch
force-pushed
the
fix-redex.py-bin-detection
branch
from
343ddfb to
bd1dc91
Compare
Signed-off-by: Leon Adomaitis <leon@adomaitis.de>
GunniBusch
force-pushed
the
fix-redex.py-bin-detection
branch
from
bd1dc91 to
f1d9211
Compare
xuhdev
reviewed
Apr 17, 2026
| extract_signing_args(args) | ||
|
|
||
| if not args.unpack_only: | ||
| args.redex_binary = find_redex_binary(args.redex_binary) |
Member
There was a problem hiding this comment.
What's the purpose of this line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_redex_binary()so validation and execution share the same autodetection pathredex-allfromPATHor a bundled binary next toredex.pyWhy
Validation previously rejected runs without
--redex-binaryeven though runtime already supported autodetecting the binary.Validation
python3 test/test_redex_args.pypython3 -m py_compile redex.py test/test_redex_args.py