Fix git-restore-mtime for newer Git on GitHub Actions (#983)#983
Closed
xuhdev wants to merge 2 commits intofacebook:mainfrom
Closed
Fix git-restore-mtime for newer Git on GitHub Actions (#983)#983xuhdev wants to merge 2 commits intofacebook:mainfrom
git-restore-mtime for newer Git on GitHub Actions (#983)#983xuhdev wants to merge 2 commits intofacebook:mainfrom
Conversation
|
@xuhdev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100770813. |
meta-codesync
bot
changed the title
git-restore-mtime for newer Git on GitHub Actionsgit-restore-mtime for newer Git on GitHub Actions (#983)
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Apr 14, 2026
Summary: The GitHub Actions runner ships Git 2.53, which is newer than Ubuntu 24.04's default Git 2.43. Git 2.53 removed `git whatchanged`, which the distro's `git-restore-mtime` package (version 2022.12) relies on. This causes `git-restore-mtime` to fail silently, leaving all source files with the checkout timestamp. With stale build cache objects, Make's dependency tracking can miss recompilation of files affected by header changes, leading to test failures from mismatched struct layouts. Install `git-restore-mtime` v2025.08 directly from upstream, which uses `git log --raw` instead of `git whatchanged`. Differential Revision: D100770813
xuhdev
force-pushed
the
export-D100770813
branch
from
e037d43 to
3501406
Compare
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Apr 14, 2026
Summary: The GitHub Actions runner ships Git 2.53, which is newer than Ubuntu 24.04's default Git 2.43. Git 2.53 removed `git whatchanged`, which the distro's `git-restore-mtime` package (version 2022.12) relies on. This causes `git-restore-mtime` to fail silently, leaving all source files with the checkout timestamp. With stale build cache objects, Make's dependency tracking can miss recompilation of files affected by header changes, leading to test failures from mismatched struct layouts. Install `git-restore-mtime` v2025.08 directly from upstream, which uses `git log --raw` instead of `git whatchanged`. Differential Revision: D100770813
xuhdev
force-pushed
the
export-D100770813
branch
from
3501406 to
e1431da
Compare
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Apr 14, 2026
Summary: The GitHub Actions runner ships Git 2.53, which is newer than Ubuntu 24.04's default Git 2.43. Git 2.53 removed `git whatchanged`, which the distro's `git-restore-mtime` package (version 2022.12) relies on. This causes `git-restore-mtime` to fail silently, leaving all source files with the checkout timestamp. With stale build cache objects, Make's dependency tracking can miss recompilation of files affected by header changes, leading to test failures from mismatched struct layouts. Install `git-restore-mtime` v2025.08 directly from upstream, which uses `git log --raw` instead of `git whatchanged`. Differential Revision: D100770813
xuhdev
force-pushed
the
export-D100770813
branch
from
e1431da to
f560cb0
Compare
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Apr 14, 2026
Summary: The GitHub Actions runner ships Git 2.53, which is newer than Ubuntu 24.04's default Git 2.43. Git 2.53 removed `git whatchanged`, which the distro's `git-restore-mtime` package (version 2022.12) relies on. This causes `git-restore-mtime` to fail silently, leaving all source files with the checkout timestamp. With stale build cache objects, Make's dependency tracking can miss recompilation of files affected by header changes, leading to test failures from mismatched struct layouts. Install `git-restore-mtime` v2025.08 directly from upstream, which uses `git log --raw` instead of `git whatchanged`. Differential Revision: D100770813
xuhdev
force-pushed
the
export-D100770813
branch
from
f560cb0 to
5bb6292
Compare
Summary: Invalidate all existing build caches to ensure a clean rebuild. This is needed because a broken `git-restore-mtime` (fixed in the next diff) may have produced cache entries with incorrect timestamps, causing Make to skip recompilation of translation units affected by header changes. Differential Revision: D100840924
Summary: The GitHub Actions runner ships Git 2.53, which is newer than Ubuntu 24.04's default Git 2.43. Git 2.53 removed `git whatchanged`, which the distro's `git-restore-mtime` package (version 2022.12) relies on. This causes `git-restore-mtime` to fail silently, leaving all source files with the checkout timestamp. With stale build cache objects, Make's dependency tracking can miss recompilation of files affected by header changes, leading to test failures from mismatched struct layouts. Install `git-restore-mtime` v2025.08 directly from upstream, which uses `git log --raw` instead of `git whatchanged`. Differential Revision: D100770813
xuhdev
force-pushed
the
export-D100770813
branch
from
5bb6292 to
f6dbed0
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
Summary: Pull Request resolved: #983 The GitHub Actions runner ships Git 2.53, which is newer than Ubuntu 24.04's default Git 2.43. Git 2.53 removed `git whatchanged`, which the distro's `git-restore-mtime` package (version 2022.12) relies on. This causes `git-restore-mtime` to fail silently, leaving all source files with the checkout timestamp. With stale build cache objects, Make's dependency tracking can miss recompilation of files affected by header changes, leading to test failures from mismatched struct layouts. Install `git-restore-mtime` v2025.08 directly from upstream, which uses `git log --raw` instead of `git whatchanged`. Reviewed By: agampe Differential Revision: D100770813 fbshipit-source-id: 42622eca3ca9afb759060bdb9ba3dfb7cb7a3d67
|
This pull request has been merged in 1f29af7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The GitHub Actions runner ships Git 2.53, which is newer than Ubuntu 24.04's default Git 2.43. Git 2.53 removed
git whatchanged, which the distro'sgit-restore-mtimepackage (version 2022.12) relies on. This causesgit-restore-mtimeto fail silently, leaving all source files with the checkout timestamp. With stale build cache objects, Make's dependency tracking can miss recompilation of files affected by header changes, leading to test failures from mismatched struct layouts.Install
git-restore-mtimev2025.08 directly from upstream, which usesgit log --rawinstead ofgit whatchanged.Differential Revision: D100770813