Regenerate test-project artifacts after emit_nogrep_annotation flag#5242
Closed
jantimon wants to merge 1 commit intofacebook:mainfrom
Closed
Regenerate test-project artifacts after emit_nogrep_annotation flag#5242jantimon wants to merge 1 commit intofacebook:mainfrom
jantimon wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
Author
|
@tyao1 can we please merge this PR so the pipelines are green again on main? |
Contributor
|
Thanks for the PR. I think this is a duplicate of #5245 which has already landed. |
Contributor
Author
|
@captbaritone are you sure? main is still broken: 
|
Contributor
|
Yes, main is still broken, well, broken again. But I think this is a different error? In fact, I think there may be two or more problems with main right now. |
Contributor
|
You can try re-basing this PR to see if these exact changes have already landed |
Contributor
Author
|
@captbaritone you were right 😄 rebasing required additional fixes so I created a new pr: #5251 - it seems to fix all open pipeline issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it looks like commit 4e2fa21 by @captbaritone added the emit_nogrep_annotation feature flag which defaults to disabled, meaning @nogrep is no longer emitted in generated files
now the main branch pipeline fails on macOS as the relay compiler is generating files without @nogrep annotations, but the checked-in files have them