Add internal query linter#708
Open
simonmar wants to merge 1 commit intofacebookincubator:mainfrom
Open
Conversation
✅ Deploy Preview for fb-oss-glean ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
meta-cla
Bot
added
the
CLA Signed
josefs
reviewed
Mar 25, 2026
simonmar
force-pushed
the
query-lint
branch
3 times, most recently
from
8df1387 to
2e0f777
Compare
When working on the compiler it's easy to accidentally break something that results in a segfault. Most of these errors can be detected by checks on the Codegen IR, in particular correct type-safety and variable-scoping. - Add Glean.Query.Lint to implement query consistency checks - Turn on query linting with `GLEAN_DEBUG=lint` or `--debug-query-lint` - Linting is automatically enabled for all tests via `withTestEnv`
Contributor
|
@simonhollis has imported this pull request. If you are a Meta employee, you can view this in D102147954. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(mostly written by Claude Opus 4.6)
When working on the compiler it's easy to accidentally break something that results in a segfault. Most of these errors can be detected by checks on the Codegen IR, in particular correct type-safety and variable-scoping.
GLEAN_DEBUG=lintor--debug-query-lintwithTestEnv