[Feature] Enable loading Callbacks from hydra configs#245
Open
Xmaster6y wants to merge 2 commits intofacebookresearch:mainfrom
Open
[Feature] Enable loading Callbacks from hydra configs#245Xmaster6y wants to merge 2 commits intofacebookresearch:mainfrom
hydra configs#245Xmaster6y wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds infrastructure for loading callback configurations from Hydra config files, establishing a pattern similar to the existing algorithm and model configuration loading mechanisms.
- Introduces
CallbackConfigbase class for defining callback configurations with YAML loading support - Adds
load_callbacks_from_hydrafunction to instantiate callbacks from Hydra DictConfig - Integrates callback loading into the experiment initialization workflow with proper merging of hydra-loaded and programmatically-provided callbacks
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| benchmarl/callbacks/common.py | Defines the CallbackConfig base class with methods for YAML loading and callback instantiation |
| benchmarl/callbacks/init.py | Initializes the callbacks module with exports and an empty callback_config_registry |
| benchmarl/hydra_config.py | Adds load_callbacks_from_hydra function and integrates callback loading into load_experiment_from_hydra |
| benchmarl/init.py | Registers callback schemas with Hydra's ConfigStore for config validation |
| test/test_callbacks.py | Adds tests for callback loading from Hydra configs, including edge cases for no callbacks and disabled callbacks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a decomposition of #220, which focuses on loading from hydra configs.
Usage: