Skip to content
This repository was archived by the owner on Oct 11, 2023. It is now read-only.

DBEpisode import export#345

Open
JackUrb wants to merge 5 commits intomainfrom
episode-import-export
Open

DBEpisode import export#345
JackUrb wants to merge 5 commits intomainfrom
episode-import-export

Conversation

@JackUrb
Copy link
Copy Markdown
Contributor

@JackUrb JackUrb commented Mar 17, 2023

Patch description
Adding import and export functionality to the EpisodeDB. Mostly just surrounds pulling from the current table after filtering on a group type, or loading all the contents of another initialized dataset into the current.

Testing steps
Will merge after successfully prepping the MultiLIGHT dataset.

@JackUrb JackUrb requested a review from mojtaba-komeili March 17, 2023 20:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2023
@JackUrb JackUrb changed the title Episode import export DBEpisode import export Mar 17, 2023
@mojtaba-komeili
Copy link
Copy Markdown
Contributor

Just a general comment about the approach. It looks to me that here we are having a single file for each episode. Considering that most of our datasets have in order of thousands of episodes, I wonder if it makes too much of bottleneck for processing the files, for example when we have task teachers.

@JackUrb
Copy link
Copy Markdown
Contributor Author

JackUrb commented Mar 20, 2023

Considering that most of our datasets have in order of thousands of episodes, I wonder if it makes too much of bottleneck for processing the files, for example when we have task teachers.

We should definitely evaluate this. At the moment I need to be compressing the GraphEvent data, so after that is done maybe we can convert to JSONLs.

This format is write-optimized for the Live deploy, so it's entirely reasonable for us to have a way to convert to a read-optimized format.

@JackUrb JackUrb marked this pull request as ready for review May 9, 2023 21:54
@facebook-github-bot
Copy link
Copy Markdown

Hi @JackUrb!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants