Conversation
|
Hi @Zehui-Lin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Thanks @Zehui-Lin for fixing the comments! Really nice to have it! Thanks :)
|
@haooooooqi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
lyttonhao
left a comment
lyttonhao
left a comment
There was a problem hiding this comment.
Looks great! Shall we also fix some comments for return values?
|
@Zehui-Lin has updated the pull request. You must reimport the pull request before landing. |
|
Of course, thanks @lyttonhao for the suggestions. :) |
|
@Zehui-Lin has updated the pull request. You must reimport the pull request before landing. |
|
@haooooooqi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@Zehui-Lin has updated the pull request. You must reimport the pull request before landing. |
4 participants
No description provided.