Skip to content

Fix: Add class name and dtype validation in copy_array_to_AlignedTable#4908

Open
LincolnBurrows2017 wants to merge 2 commits intofacebookresearch:mainfrom
LincolnBurrows2017:main
Open

Fix: Add class name and dtype validation in copy_array_to_AlignedTable#4908
LincolnBurrows2017 wants to merge 2 commits intofacebookresearch:mainfrom
LincolnBurrows2017:main

Conversation

@LincolnBurrows2017
Copy link
Copy Markdown

This PR fixes a TODO in the copy_array_to_AlignedTable function to add proper class name checking.

Previously, the function would fail with a confusing error if the wrong type of AlignedTable was passed. Now it provides clear type checking and error messages.

Changes:

  • Added class name validation to ensure the input is an AlignedTable
  • Added dtype validation to ensure array matches the expected type
  • Provides clear TypeError messages instead of cryptic assertion errors

This fixes a TODO to add proper class name checking in copy_array_to_AlignedTable function.
Previously, the function would fail with a confusing error if the wrong type of
AlignedTable was passed. Now it provides clear type checking and error messages.
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Mar 11, 2026

Hi @LincolnBurrows2017!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@mnorris11
Copy link
Copy Markdown
Contributor

Hi @LincolnBurrows2017 , thanks for fixing this TODO, if you sign the CLA we can import and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants