Fix: Add class name and dtype validation in copy_array_to_AlignedTable#4908
Fix: Add class name and dtype validation in copy_array_to_AlignedTable#4908LincolnBurrows2017 wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
This fixes a TODO to add proper class name checking in copy_array_to_AlignedTable function. Previously, the function would fail with a confusing error if the wrong type of AlignedTable was passed. Now it provides clear type checking and error messages.
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Hi @LincolnBurrows2017 , thanks for fixing this TODO, if you sign the CLA we can import and merge it. |
This PR fixes a TODO in the
copy_array_to_AlignedTablefunction to add proper class name checking.Previously, the function would fail with a confusing error if the wrong type of AlignedTable was passed. Now it provides clear type checking and error messages.
Changes: