fix: add CMake warning infrastructure (opt-in strict compiler warnings)#4932
Open
maxwbuckley wants to merge 2 commits intofacebookresearch:mainfrom
Open
fix: add CMake warning infrastructure (opt-in strict compiler warnings)#4932maxwbuckley wants to merge 2 commits intofacebookresearch:mainfrom
maxwbuckley wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
4 tasks
Contributor
|
@alibeklfc has imported this pull request. If you are a Meta employee, you can view this in D96995151. |
maxwbuckley
force-pushed
the
fix/warnings-cmake-infra
branch
from
305b422 to
eed281b
Compare
Mechanical fixes for compiler warnings found with -Wall -Wextra -Wshadow. No functional changes — only variable renames, unused parameter annotations, signed/unsigned casts, and [[fallthrough]] attributes. Part 1/13 of the compiler warnings cleanup (split from PR facebookresearch#4810). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
maxwbuckley
force-pushed
the
fix/warnings-cmake-infra
branch
from
eed281b to
e07b03a
Compare
1 task
…s, and OnDiskInvertedLists Fix sign-compare, unused-parameter, and type-limits warnings caught by the new -Werror warnings CI job. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmake/StrictCompilerWarnings.cmake) with 3 warning levels (basic, standard, strict) and optional-Werrorsupportfaiss_add_warnings()to all build targets via CMakeLists.txt updatesResultHandler.h: sign-compare (intvssize_tloop variable)IDSelector.h: unused parameter inIDSelectorAll::is_memberio_macros.h: redundantsize >= 0checks on unsignedsize_tin READVECTOR/READXBVECTOROnDiskInvertedLists.cpp: sign-compare and type-limits warnings across several variablesDefault is level 0 (off) so this is fully opt-in and does not break existing builds.
Part 1/13 of the compiler warnings cleanup (split from #4810 per maintainer request).
Test plan
-Werror🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com