fix: resolve compiler warnings in top-level FAISS source files#4943
Closed
maxwbuckley wants to merge 2 commits intofacebookresearch:mainfrom
Closed
fix: resolve compiler warnings in top-level FAISS source files#4943maxwbuckley wants to merge 2 commits intofacebookresearch:mainfrom
maxwbuckley wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
4 tasks
Contributor
|
@alibeklfc has imported this pull request. If you are a Meta employee, you can view this in D96996987. |
maxwbuckley
force-pushed
the
fix/warnings-top-level
branch
from
18eec3a to
0613830
Compare
Mechanical fixes for compiler warnings found with -Wall -Wextra -Wshadow. No functional changes — only variable renames, unused parameter annotations, signed/unsigned casts, and [[fallthrough]] attributes. Part 12/13 of the compiler warnings cleanup (split from PR facebookresearch#4810). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
maxwbuckley
force-pushed
the
fix/warnings-top-level
branch
from
0613830 to
3624fce
Compare
1 task
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
@alibeklfc merged this pull request in 44f57ba. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Wshadow,-Wunused-parameter,-Wformat, and-Woverloaded-virtualAll changes are mechanical. No functional changes.
Part 12/13 of the compiler warnings cleanup (split from #4810 per maintainer request).
Test plan
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com