enable specifying a subset of SIMD levels that are implemented at dispatching time.#4952
Open
mdouze wants to merge 1 commit intofacebookresearch:mainfrom
Open
enable specifying a subset of SIMD levels that are implemented at dispatching time.#4952mdouze wants to merge 1 commit intofacebookresearch:mainfrom
mdouze wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
…patching time. Summary: So far the `with_simd_level` function would assume that all implementations are available for each function. This is not the case, and is effectively not the case when we enable AVX512_SPR. This diff has a specialized `with_selected_simd_levels` that takes a bitmask of the available implementations as template parameter. The previous `with_simd_level` remains, it assumes AVX2, NEON and AVX512 implementations are available. Differential Revision: D96943554
Contributor
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Mar 19, 2026
…dispatching time. (facebookresearch#4952) Summary: The link with the original diff D96943554 was lost for some reason, so reviving So far the with_simd_level function would assume that all implementations are available for each function. This is not the case, and is effectively not the case when we enable AVX512_SPR. This diff has a specialized with_selected_simd_levels that takes a bitmask of the available implementations as template parameter. The previous with_simd_level remains, it assumes AVX2, NEON and AVX512 implementations are available. Differential Revision: D97247328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
So far the
with_simd_levelfunction would assume that all implementations are available for each function. This is not the case, and is effectively not the case when we enable AVX512_SPR.This diff has a specialized
with_selected_simd_levelsthat takes a bitmask of the available implementations as template parameter.The previous
with_simd_levelremains, it assumes AVX2, NEON and AVX512 implementations are available.Differential Revision: D96943554