fix: resolve compiler warnings in graph-based index implementations#4956
Closed
maxwbuckley wants to merge 1 commit intofacebookresearch:mainfrom
Closed
fix: resolve compiler warnings in graph-based index implementations#4956maxwbuckley wants to merge 1 commit intofacebookresearch:mainfrom
maxwbuckley wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
4 tasks
Resolve -Wall -Wextra -Wshadow warnings in graph index files: - Rename constructor/function parameters that shadow member variables - Add explicit casts for sign comparison warnings - Add [[maybe_unused]] attributes where appropriate - Fix unused parameter warnings Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
maxwbuckley
force-pushed
the
fix/warnings-graph-indexes
branch
from
72fa39d to
6a34687
Compare
1 task
Contributor
|
@alibeklfc has imported this pull request. If you are a Meta employee, you can view this in D97359107. |
Contributor
|
@alibeklfc merged this pull request in 4db01e3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Wshadow(variable renames),-Wunused-parameter, and-Wimplicit-fallthroughAll changes are mechanical. No functional changes.
Part 3/13 of the compiler warnings cleanup (split from #4810 per maintainer request).
Test plan
🤖 Generated with Claude Code