Update outdated C++17 and Python 2 references#5045
Closed
Chessing234 wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Update outdated C++17 and Python 2 references#5045Chessing234 wants to merge 1 commit intofacebookresearch:mainfrom
Chessing234 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
- Update C++ language level from C++17 to C++20 in CONTRIBUTING.md to match the actual CMake configuration (CMAKE_CXX_STANDARD 20) - Remove outdated "progressively dropping python2 support" note from contrib/README.md (Python 2 reached EOL in January 2020) - Update shebangs from python2 to python3 in benchs/kmeans_mnist.py, benchs/bench_gpu_1bn.py, and benchs/bench_vector_ops.py Signed-off-by: Taksh <takshkothari09@gmail.com>
Contributor
|
@alibeklfc has imported this pull request. If you are a Meta employee, you can view this in D99691731. |
Contributor
|
@alibeklfc merged this pull request in faeac86. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTRIBUTING.mdto match the actual CMake configuration (CMAKE_CXX_STANDARD 20in the rootCMakeLists.txt)contrib/README.md(Python 2 reached end-of-life in January 2020 and Faiss requires Python 3)python2topython3in three benchmark scripts:benchs/kmeans_mnist.py,benchs/bench_gpu_1bn.py, andbenchs/bench_vector_ops.pyTest plan
CMakeLists.txt(set(CMAKE_CXX_STANDARD 20)) andINSTALL.md(which already references "a C++20 compiler")🤖 Generated with Claude Code