Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D99880597. (Because this pull request was imported automatically, there will not be any future comments.) |
…ueues Replace the single `queue` field on `_Node` with explicit `input_queues` and `output_queues` sequences, assigned at construction time. Previously, nodes implicitly derived their input queue from `upstream[0].queue` at coroutine-build time. This works for linear pipelines but breaks down for fan-out patterns (PathVariants) where: - A router writes to multiple output queues (one per path) - A path's first pipe reads from a dedicated queue, not upstream's output With explicit queue fields, the data-flow wiring is visible in the node graph structure rather than scattered across special-case logic in `_build_node`. Queue assignments by node type: - Source: `input_queues=[]`, `output_queues=[out_q]` - Pipe/Aggregate/Disaggregate: `input_queues=[upstream.output_queues[0]]`, `output_queues=[out_q]` - Merge: `input_queues=[n.output_queues[0] for n in upstream]`, `output_queues=[out_q]` - Sink: `input_queues=[upstream.output_queues[0]]`, `output_queues=[out_q]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the single
queuefield on_Nodewith explicitinput_queuesand
output_queuessequences, assigned at construction time.Previously, nodes implicitly derived their input queue from
upstream[0].queueat coroutine-build time. This works for linearpipelines but breaks down for fan-out patterns (PathVariants) where:
With explicit queue fields, the data-flow wiring is visible in the node
graph structure rather than scattered across special-case logic in
_build_node.Queue assignments by node type:
input_queues=[],output_queues=[out_q]input_queues=[upstream.output_queues[0]],output_queues=[out_q]input_queues=[n.output_queues[0] for n in upstream],output_queues=[out_q]input_queues=[upstream.output_queues[0]],output_queues=[out_q]