Fix oracle_cute_cpp to skip instead of error when nvidia is absent#10
Merged
jduprat merged 1 commit intofacebookresearch:mainfrom Apr 9, 2026
Merged
Fix oracle_cute_cpp to skip instead of error when nvidia is absent#10jduprat merged 1 commit intofacebookresearch:mainfrom
jduprat merged 1 commit intofacebookresearch:mainfrom
Conversation
Wrap the importlib.util.find_spec call in _module_root with a
try/except catching (ModuleNotFoundError, ValueError). Previously,
find_spec("nvidia.cuda_runtime") raised ModuleNotFoundError when the
nvidia parent package was not installed, crashing before the fixture's
skip logic could run. Now _module_root returns None, the candidate
include dirs list omits it, and the fixture skips gracefully.
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue found in CI when trying to release 0.2.1